Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unneeded code in SQLite3\Table and fix PHPDoc types in Database #8703

Merged
merged 2 commits into from
Apr 5, 2024
Merged

refactor: remove unneeded code in SQLite3\Table and fix PHPDoc types in Database #8703

merged 2 commits into from
Apr 5, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 3, 2024 •
edited
Loading

Description

  • fix PHPDoc types in Database
  • remove unneeded code in SQLite3\Table

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Apr 3, 2024
@kenjis kenjis force-pushed the fix-PHPDoc-types-in-Database branch from 6f30e3c to bf3677c Compare April 3, 2024 22:02
@kenjis kenjis added the refactor Pull requests that refactor code label Apr 3, 2024
@kenjis kenjis changed the title docs: fix PHPDoc types in Database refactor: unneeded code in SQLite3\Table Apr 3, 2024
@kenjis kenjis changed the title refactor: unneeded code in SQLite3\Table refactor: unneeded code in SQLite3\Table and fix PHPDoc types in Database Apr 3, 2024
@kenjis kenjis changed the title refactor: unneeded code in SQLite3\Table and fix PHPDoc types in Database refactor: remove unneeded code in SQLite3\Table and fix PHPDoc types in Database Apr 3, 2024
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Apr 3, 2024
@kenjis kenjis merged commit 07e3999 into codeigniter4:develop Apr 5, 2024
56 checks passed
@kenjis kenjis deleted the fix-PHPDoc-types-in-Database branch April 5, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn