Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: TypeError when Time is passed to Model #8738

Merged
merged 2 commits into from
Apr 10, 2024
Merged

fix: TypeError when Time is passed to Model #8738

merged 2 commits into from
Apr 10, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 9, 2024 •
edited
Loading

Description
Follow-up #8538
See #7177
See codeigniter4/shield#1092

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Apr 9, 2024
@kenjis kenjis mentioned this pull request Apr 9, 2024
Closed
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Apr 9, 2024
@datamweb datamweb mentioned this pull request Apr 9, 2024
Closed
@kenjis kenjis merged commit 8dccc27 into codeigniter4:develop Apr 10, 2024
40 checks passed
@kenjis kenjis deleted the fix-Model-handling-Time branch April 10, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @datamweb