Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: system/CLI/BaseCommand.php #8741

Merged

Conversation

mcsaygili
Copy link
Contributor

@mcsaygili mcsaygili commented Apr 9, 2024

Description
See #8732

  • replace empty()
  • add types

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Apr 9, 2024
@mcsaygili
Copy link
Contributor Author

Failed at PHPUnit / Others (8.3) / Sanity Tests (pull_request) step.
After adding .gitkeep file to /CodeIgniter4/writable/debugbar/ passed.
Should I add the .gitkeep ?

@kenjis
Copy link
Member

kenjis commented Apr 9, 2024

Sorry, now PHPUnit checks fail.
It is addressed in #8740.

@kenjis
Copy link
Member

kenjis commented Apr 10, 2024

I merged #8740.
Can you rebase this PR?
See https://github.com/codeigniter4/CodeIgniter4/blob/develop/contributing/workflow.md#updating-your-branch
If you have questions, feel free to ask.

@mcsaygili mcsaygili force-pushed the refactor-system-CLI-BaseCommand.php branch from 7948d5d to a5213fe Compare April 10, 2024 06:44
@mcsaygili
Copy link
Contributor Author

mcsaygili commented Apr 10, 2024

I tried using an IDE, but using the command line as you mentioned to be easier. Can you look into it?

system/CLI/BaseCommand.php Outdated Show resolved Hide resolved
@kenjis kenjis merged commit e14e145 into codeigniter4:develop Apr 11, 2024
40 checks passed
@kenjis
Copy link
Member

kenjis commented Apr 11, 2024

Thank you!

Leaning git commands is very useful. git commands are the only common language for Git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Pull requests that refactor code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants