Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Factories::get() cannot get defined classes #8744

Merged
merged 2 commits into from
Apr 11, 2024
Merged

fix: Factories::get() cannot get defined classes #8744

merged 2 commits into from
Apr 11, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 10, 2024 •
edited
Loading

Description
If we define() and get(), the error like this occurs:

ErrorException: Undefined array key "models"

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Apr 10, 2024
@kenjis kenjis force-pushed the fix-Factories-cannot-get-defined-class branch from 06efdcc to c16b1ff Compare April 10, 2024 02:17
@kenjis kenjis force-pushed the fix-Factories-cannot-get-defined-class branch from c16b1ff to ca66cb7 Compare April 10, 2024 02:32
@kenjis kenjis merged commit 48be4ac into codeigniter4:develop Apr 11, 2024
40 checks passed
@kenjis kenjis deleted the fix-Factories-cannot-get-defined-class branch April 11, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@datamweb datamweb datamweb approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @datamweb