Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [CURLRequest] construct param $config is not used #8761

Merged

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Apr 11, 2024

Description
The construct parameter should be used.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Apr 11, 2024
@github-actions github-actions bot added the stale Pull requests with conflicts label Apr 11, 2024
Copy link

👋 Hi, @kenjis!

We detected conflicts in your PR against the base branch 🙊
You may want to sync 🔄 your branch with upstream!

Ref: Syncing Your Branch

The construct param should be used.
@kenjis kenjis force-pushed the fix-CURLRequest-unused-constructor-param branch from 4267477 to 631f9ab Compare April 11, 2024 22:50
@kenjis kenjis removed the stale Pull requests with conflicts label Apr 11, 2024
@kenjis kenjis merged commit ea7c719 into codeigniter4:develop Apr 12, 2024
40 checks passed
@kenjis kenjis deleted the fix-CURLRequest-unused-constructor-param branch April 12, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants