Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused undefined param $raw in MockCache::save() #8847

Merged
merged 1 commit into from
May 3, 2024
Merged

fix: remove unused undefined param $raw in MockCache::save() #8847

merged 1 commit into from
May 3, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 2, 2024 •
edited
Loading

Description
It is not defined in the interface or other classes, and not used at all.
See also #8846 (comment)

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis
fix: remove unused undefined param $raw
1ff8889 
It is not defined in the interface and other classes, and not used at all.
@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label May 2, 2024
@kenjis kenjis merged commit c23bc4c into codeigniter4:develop May 3, 2024
41 checks passed
@kenjis kenjis deleted the fix-MockCache-save branch May 3, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddevsr ddevsr ddevsr approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @ddevsr