Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [Model] casting may throw InvalidArgumentException: Invalid parameter: nullable #8870

Merged
merged 2 commits into from
May 10, 2024
Merged

fix: [Model] casting may throw InvalidArgumentException: Invalid parameter: nullable #8870

merged 2 commits into from
May 10, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented May 8, 2024 •
edited
Loading

Description
Fixes #8860

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label May 8, 2024
@kenjis kenjis mentioned this pull request May 8, 2024
Closed
@kenjis kenjis changed the title fix: [DataCaster] InvalidArgumentException: Invalid parameter: nullable fix: [Model] casting InvalidArgumentException: Invalid parameter: nullable May 8, 2024
@kenjis kenjis changed the title fix: [Model] casting InvalidArgumentException: Invalid parameter: nullable fix: [Model] casting may throw InvalidArgumentException: Invalid parameter: nullable May 8, 2024
neznaika0
neznaika0 approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@neznaika0 neznaika0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved

@kenjis kenjis merged commit e68553f into codeigniter4:develop May 10, 2024
40 checks passed
@kenjis kenjis deleted the fix-DataCaster-nullable branch May 10, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@datamweb datamweb datamweb approved these changes

@neznaika0 neznaika0 neznaika0 approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: [DatetimeCast] Invalid parameter: nullable
4 participants
@kenjis @michalsn @datamweb @neznaika0