Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Model::find() returns incorrect data with casting #8933

Merged
merged 2 commits into from
Jun 8, 2024
Merged

fix: Model::find() returns incorrect data with casting #8933

merged 2 commits into from
Jun 8, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jun 5, 2024 •
edited
Loading

Description
See https://forum.codeigniter.com/showthread.php?tid=91006

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Jun 5, 2024
@kenjis kenjis force-pushed the fix-Model-find-with-casts branch 3 times, most recently from eae7229 to 8610cca Compare June 5, 2024 09:11
@kenjis kenjis force-pushed the fix-Model-find-with-casts branch from 8610cca to 977059b Compare June 5, 2024 09:26
@kenjis kenjis added the database Issues or pull requests that affect the database layer label Jun 5, 2024
@kenjis kenjis merged commit 801b4f3 into codeigniter4:develop Jun 8, 2024
41 checks passed
@kenjis kenjis deleted the fix-Model-find-with-casts branch June 8, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kenjis @michalsn