Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use first class callable on function call #9004

Merged
merged 1 commit into from
Jun 26, 2024
Merged

refactor: use first class callable on function call #9004

merged 1 commit into from
Jun 26, 2024

Conversation

samsonasik
Copy link
Member

Description

Detected by latest rector dev-main

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍

@samsonasik samsonasik added the refactor Pull requests that refactor code label Jun 26, 2024
@samsonasik
Copy link
Member Author

Thank you @kenjis for the review, let's merge ;)

@samsonasik samsonasik merged commit fc5dd88 into codeigniter4:develop Jun 26, 2024
41 checks passed
@samsonasik samsonasik deleted the refactor-first-class branch June 26, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TimexPeachtree TimexPeachtree TimexPeachtree approved these changes

@kenjis kenjis kenjis approved these changes

@paulbalandan paulbalandan Awaiting requested review from paulbalandan

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @kenjis @TimexPeachtree