Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Enable phpunit 10 attribute Rector rules #9015

Merged
merged 2 commits into from
Jun 30, 2024
Merged

refactor: Enable phpunit 10 attribute Rector rules #9015

merged 2 commits into from
Jun 30, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Jun 30, 2024 •
edited
Loading

Description

Since we require phpunit 10 and we require php 8.1 already, rector attribute rules can be enabled.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍

@samsonasik
Copy link
Member Author

Thank you @paulbalandan for the review, let's merge ;)

@samsonasik samsonasik merged commit bab8828 into codeigniter4:develop Jun 30, 2024
41 checks passed
@samsonasik samsonasik deleted the refactor-enable-phpunit-attribute branch June 30, 2024 15:17
@kenjis kenjis added the refactor Pull requests that refactor code label Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

@kenjis kenjis Awaiting requested review from kenjis

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @paulbalandan @kenjis