Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support CURL HTTP3 #9145

Merged
merged 2 commits into from
Sep 12, 2024
Merged

feat: support CURL HTTP3 #9145

merged 2 commits into from
Sep 12, 2024

Conversation

ddevsr
Copy link
Collaborator

@ddevsr ddevsr commented Aug 23, 2024 •
edited by kenjis
Loading

Description
PHP 8.4 coming soon, see #9116

Reference:

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@ddevsr ddevsr marked this pull request as draft August 23, 2024 08:44
@kenjis kenjis added enhancement PRs that improve existing functionalities 4.6 labels Aug 23, 2024
@ddevsr

This comment was marked as off-topic.

Sign in to view
@ddevsr ddevsr requested a review from kenjis September 10, 2024 05:07
@kenjis
Copy link
Member

kenjis commented Sep 10, 2024

Run git rebase.

@ddevsr ddevsr marked this pull request as ready for review September 10, 2024 10:08
michalsn
michalsn approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kenjis kenjis mentioned this pull request Sep 6, 2024
Open
15 tasks
@kenjis kenjis merged commit c05260c into codeigniter4:4.6 Sep 12, 2024
45 checks passed
@kenjis
Copy link
Member

kenjis commented Sep 12, 2024

@ddevsr Thank you!

@ddevsr ddevsr deleted the CURL-CONSTANT branch September 12, 2024 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@kenjis kenjis kenjis approved these changes

@paulbalandan paulbalandan Awaiting requested review from paulbalandan

Assignees
No one assigned
Labels
4.6 enhancement PRs that improve existing functionalities
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ddevsr @kenjis @michalsn