Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: enable ClosureReturnTypeRector #9187

Merged
merged 2 commits into from
Sep 10, 2024
Merged

refactor: enable ClosureReturnTypeRector #9187

merged 2 commits into from
Sep 10, 2024

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Sep 10, 2024 •
edited
Loading

Description

Add closure return type should be safe, this PR adds it via ClosureReturnTypeRector

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik
Copy link
Member Author

Ready to merge 👍

@kenjis
Copy link
Member

kenjis commented Sep 10, 2024

Coding Standards check Failed.

MGatner
MGatner requested changes Sep 10, 2024
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code all looks good, but once again Rector doesn't match up with our styles.

@samsonasik
Copy link
Member Author

cs fixed 👍

@samsonasik
Copy link
Member Author

All green 👍 let's merge, thank you @kenjis @MGatner for the review

@samsonasik samsonasik merged commit 1528d3d into codeigniter4:develop Sep 10, 2024
41 checks passed
@samsonasik samsonasik deleted the refactor-enable-closure-return branch September 10, 2024 09:54
@kenjis kenjis added the refactor Pull requests that refactor code label Oct 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner requested changes

@kenjis kenjis Awaiting requested review from kenjis

@paulbalandan paulbalandan Awaiting requested review from paulbalandan

Assignees
No one assigned
Labels
refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samsonasik @kenjis @MGatner