Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sv-SE] Updated strings to match the format of 4.3 #333

Closed
wants to merge 2 commits into from
Closed

[sv-SE] Updated strings to match the format of 4.3 #333

wants to merge 2 commits into from

Conversation

tangix
Copy link
Contributor

@tangix tangix commented Sep 12, 2022

Updated the strings to match quote-style introduced in 4.3 by codeigniter4/CodeIgniter4#6474

@kenjis kenjis added the 4.3 label Sep 12, 2022
@paulbalandan paulbalandan reopened this Jan 10, 2023
@tangix
Copy link
Contributor Author

tangix commented Jan 10, 2023

Hmmm.... since this PR is pretty old I wonder if I should rebase this on a more recent version and open a new PR.

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, without knowing the language.

@@ -14,6 +14,6 @@
'invalidSavePath' => 'Session: Angivna sökvägen "{0}" är inte en katalog, existerar inte eller kan inte skapas.',
'writeProtectedSavePath' => 'Session: Angivna sökvägen "{0}" är inte skrivbar för PHP processen.',
'emptySavePath' => 'Session: Ingen sökväg har angetts.',
'invalidSavePathFormat' => 'Session: Ogiltigt format för Redis: {0}',
'invalidSameSiteSetting' => 'Session: SameSite måste vara None, Lax, Strict, eller en blank sträng. Givet: {0}',
'invalidSavePathFormat' => 'Session: Ogiltig sökväg för Redis: "{0}"',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this a mistake before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MGatner
No, this was related to codeigniter4/CodeIgniter4#6474 and I branched and updated sv-SE to match that original PR for English.
Now it seems like the test-suite has moved forward so there are missing strings in this old PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tangix you can open a new PR if that would be faster for you.

@tangix tangix marked this pull request as draft January 11, 2023 17:36
@tangix
Copy link
Contributor Author

tangix commented Jan 11, 2023

Scratch this PR. I'm trying to create a new one.

@tangix tangix closed this Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants