Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[de] Convert windows-1252 files to UTF-8 #399

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

LeMyst
Copy link
Contributor

@LeMyst LeMyst commented Sep 9, 2023

Description
Some DE files are encoded in "windows-1252" charset instead of UTF-8.
I think it's a mistake and after a quick research I didn't find a closed issue about this or any logic why these files are in a different encoding.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@LeMyst LeMyst changed the title Convert windows-1252 files to UTF-8 Convert windows-1252 files to UTF-8 (de language) Sep 9, 2023
@LeMyst LeMyst changed the title Convert windows-1252 files to UTF-8 (de language) [de] Convert windows-1252 files to UTF-8 Sep 9, 2023
@paulbalandan
Copy link
Member

Out of scope of this PR.. How can we check if all files are encoded properly? Can we add an auto-review test for that?

@kenjis
Copy link
Member

kenjis commented Sep 10, 2023

@paulbalandan

$ find Language/de/ -type f -exec file --mime {} \; | grep -v charset=utf-8 | grep -v charset=us-ascii
Language/de//Files.php: text/x-php; charset=iso-8859-1
Language/de//Test.php: text/x-php; charset=iso-8859-1
Language/de//Publisher.php: text/x-php; charset=iso-8859-1

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving this but I have no idea 🤷‍♂️

Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot read de, but every file encoding is UTF-8.

@paulbalandan paulbalandan merged commit 372cf69 into codeigniter4:develop Sep 11, 2023
10 checks passed
@paulbalandan
Copy link
Member

Thank you, @LeMyst

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants