Update to CI v4.4.1 #393
Merged
Update to CI v4.4.1 #393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why does the test fail? It passes on my local. https://github.com/codeigniter4projects/website/actions/runs/6033515315/job/16370306869?pr=393 |
kenjis
commented
Aug 31, 2023
phpunit.xml.dist
Outdated
| @@ -74,6 +74,8 @@ | |||
|
|
|||
| <php> | |||
| <env name="XDEBUG_MODE" value="coverage"/> | |||
| <env name="app.forceGlobalSecureRequests" value="false"/> | |||
There was a problem hiding this comment.
This code makes the tests pass.
So why did the tests pass without this code in the past?
There was a problem hiding this comment.
I found a bug in CI v4.4.0 FeatureTestTrait. See codeigniter4/CodeIgniter4#7890
So this addition should be removed.
There was a problem hiding this comment.
Nice sleuthing! We can proceed here with test workaround or wait for 4.4.1
Arhell
approved these changes
Sep 1, 2023
|
Rebased to resolve conflict. |
lonnieezell
approved these changes
Sep 1, 2023
Conflicts: app/Config/Routes.php app/Config/Routing.php
composer cs-fix
5 tasks
MGatner
approved these changes
Sep 4, 2023
Conflicts: Config/ForeignCharacters.php app/Config/Autoload.php app/Config/Modules.php
|
Updated to v4.4.1. |
lonnieezell
approved these changes
Sep 5, 2023
MGatner
approved these changes
Sep 9, 2023
|
Still good! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add<env name="app.forceGlobalSecureRequests" value="false"/>in phpunit.xml.dist