Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: GitHub network error handling #423

Merged

Conversation

kenjis
Copy link
Contributor

@kenjis kenjis commented Feb 16, 2024

If GitHub is unreachable, the site returns "Whoops!" and we cannot see the contents.

@kenjis kenjis changed the title ffix: GitHub network error handling fix: GitHub network error handling Feb 16, 2024
@coveralls
Copy link

coveralls commented Feb 16, 2024

Pull Request Test Coverage Report for Build 7937185845

Details

  • -4 of 6 (33.33%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+1.3%) to 76.519%

Changes Missing Coverage Covered Lines Changed/Added Lines %
app/Controllers/Contribute.php 0 2 0.0%
app/Controllers/Download.php 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
app/Controllers/Contribute.php 1 57.14%
Totals Coverage Status
Change from base Build 7924138747: 1.3%
Covered Lines: 277
Relevant Lines: 362

💛 - Coveralls

@kenjis kenjis merged commit e009184 into codeigniter4projects:develop Feb 17, 2024
9 checks passed
@kenjis kenjis deleted the fix-network-error-handling branch February 17, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants