Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improvement: App Store Connect JWT cache logging and lifecycle #188

Merged
merged 3 commits into from
Jan 4, 2022
Merged

Improvement: App Store Connect JWT cache logging and lifecycle #188

merged 3 commits into from
Jan 4, 2022

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Jan 4, 2022 •
edited
Loading

Improvements to App Store Connect JSON web token management.

  • Include App Store Connect API key identifier in verbose log to indicate for which keys JSON web token is either generated or loaded from cache.
  • Revoke invalid JSON web token when unauthorized request retries are exhausted so that the same token will not be used for subsequent command invocations from disk cache.

@priitlatt
Improve App Store Conenct JWT cache
e4f8049 
- Log for which key JWT is loaded or generated
- Revoke JWT cache if unauthorized request retries are exhausted
@priitlatt
Update tests
cd9ab41
@priitlatt
Update changelog
e766334
@priitlatt priitlatt marked this pull request as ready for review January 4, 2022 09:54
@priitlatt priitlatt merged commit 3a2ecc4 into master Jan 4, 2022
@priitlatt priitlatt deleted the improvement/app-store-connect-jwt-caching branch January 4, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemii-yanushevskyi artemii-yanushevskyi artemii-yanushevskyi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@priitlatt @artemii-yanushevskyi