Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: App Store Connect API private key validation #196

Merged

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Jan 27, 2022

Check that App Store Connect API keys specified by --private-key argument for app-store-connect are valid PEM encoded private keys, as opposed to checking just key contents prefix as it used to be.
This change will remedy the unexpected failures that happen due to JWT generation using invalid private keys.

Other changes inclued here:

  • Do not expose specified private key in error log. Instead just state that it is not a valid PEM encoded key.
  • Log JWT cache revoking with debug level instead of info, as it is mosly useless noise in the logs.

Chagnes apply to actions:

  • all app-store-connect actions.

@priitlatt priitlatt changed the title Improvement/app store connect private key validation Improvement: App Store Connect API private key validation Jan 27, 2022
@priitlatt priitlatt marked this pull request as ready for review January 27, 2022 15:34
@priitlatt priitlatt merged commit eff1869 into master Jan 28, 2022
@priitlatt priitlatt deleted the improvement/app-store-connect-private-key-validation branch January 28, 2022 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants