Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Ignore uncompatible devices when creating provisioning profiles #200

Merged
merged 2 commits into from
Feb 3, 2022

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Feb 2, 2022

There is a bug in app-store-connect fetch-signing-files action related to provisioning profile creation. When requested AdHoc or development provisioning profile, that is profiles that can contain allowed devices identifiers, does not exist then the tool automatically tries to include all eligible devices registered in Apple Developer Portal in the new profile during creation.

However, up until now Apple TV devices were also included when iOS provisioning profiles were created, which is not allowed, despite the fact that devices Apple TV devices share the same platform attribute with iPhones, iPads, iPods and Apple Watches.

This makes the Create a Profile request

POST https://api.appstoreconnect.apple.com/v1/profiles

fail with 409 error response:

{
    "errors": [
        {
            "id": "177ddcb8-8dc7-44f8-8889-d0117978fbbd",
            "status": "409",
            "code": "ENTITY_ERROR",
            "title": "There is a problem with the request entity",
            "detail": "Invalid deviceClass for profile type."
        }
    ]
}

Now distinct separation is made using the deviceClass attribute on the device resource to filter out which devices can be included in the provisioning profile.

Updated actions:

  • app-store-connect fetch-signing-files.

@priitlatt priitlatt marked this pull request as ready for review February 3, 2022 09:00
@priitlatt priitlatt merged commit 0af74aa into master Feb 3, 2022
@priitlatt priitlatt deleted the bugfix/profile-creation-devices branch February 3, 2022 09:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants