Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvement: hide environment variables in altool output #238

Merged

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Jun 3, 2022

Action app-store-connect publish uses xcrun altool to perform the package upload to App Store Connect. With some Xcode versions altool logs out all environment variables and their values as a Ruby hashmap in case of an error.
Usually this is not a desired behaviour, especially in a CI envioronment. This is because environment variables can contain various secrets such as private keys, passwords etc, and they would leak to build logs that way.

In order to tackle this, replace environment variable values in altool output with ellipsis. That is

ENV: {"VARIABLE_1" => "value", "KEY" => "other value"}

becomes

ENV: {"VARIABLE_1" => "...", "KEY" => "..."}

in the output.

Note that in the verbose logs full unmodified altool output is available for inspection.

Updated actions

  • app-store-connect publish

@priitlatt priitlatt marked this pull request as ready for review June 6, 2022 08:44
@priitlatt priitlatt changed the title Improvement/hide environment variables in altool output Improvement: hide environment variables in altool output Jun 6, 2022
@priitlatt priitlatt merged commit 1007c47 into master Jun 6, 2022
@priitlatt priitlatt deleted the improvement/hide-environment-variables-in-altool-output branch June 6, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant