Refactoring: Migrate to Poetry dependency management, packaging and PyPI distribution #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priitlatt
changed the title
priitlatt
commented
Jun 28, 2022
helinanever
reviewed
Jun 30, 2022
Co-authored-by: helinanever <36853001+helinanever@users.noreply.github.com>
remarkov
approved these changes
Jun 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The main goal of this pull request is to migrate the project to unified PEP 518 compliant build system by using Poetry dependency management and packaging tool.
Current situation
Up until now
What was done
Old project configuration files
setup.cfg,Pipenvandsetup.pywere replaced bypyproject.tomland.flake8.Testing, building and distribution workflows in CI scripts were updated to use Poetry. New
release-testCI workflow was added to publish test releases to PyPI test environment which adds options to test distribution related changes.Single code change renaming Ruby script
bin/code_signing_manager.rbtosrc/codemagic/scripts/code_signing_manager.rb, accompanied by minor edit tocode_signing_settings_manager.py, was required by the fact that there is no easy way to define non-Python shell scripts using Poetry.pre-commit hooks were introduced to ensure unified code style from all contributors without running unnecessary CI jobs.
Examples in readme file were brough up to date and information on how to set up development environment was added.