-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Retry App Store Connect API requests that fail with server errors #249
Merged
priitlatt
merged 19 commits into
master
from
feature/retry-app-store-connect-500-errors
Jul 26, 2022
Merged
Feature: Retry App Store Connect API requests that fail with server errors #249
priitlatt
merged 19 commits into
master
from
feature/retry-app-store-connect-500-errors
Jul 26, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
priitlatt
changed the base branch from
master
to
logging/unexpected-errors-logging
July 25, 2022 12:52
…gic-ci-cd/cli-tools into feature/retry-app-store-connect-500-errors
artemii-yanushevskyi
approved these changes
Jul 26, 2022
…ature/retry-app-store-connect-500-errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes App Store Connect API responds to valid HTTP requests with server error response.
Those responses have status code
500
and have response payload asSince this failure is unavoidable by the user, we should retry the request in case of server errors. As failed HTTP request break the whole action that depends on this failed App Store Connect API call, whole CI jobs can fail.
A common example of such interruption is when
app-store-connect submit-to-app-store
action is terminated due to500
error in the middle of processing the upload.With the changes in this PR
app-store-connect
tool gets a new option--api-server-error-retries
that accepts integer values to define how many times App Store Connect API requests that fail due to server errors should be retried. By default three retry attemps are made.Updated actions:
app-store-connect
actions and subactions.