Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: log project build settings #266

Merged
merged 13 commits into from
Sep 29, 2022

Conversation

artemii-yanushevskyi
Copy link
Contributor

Run xcodebuild -showBuildSettings as part of xcode-project build-ipa. This will print out all relevant information about the project that is being built.

By default, the output is available in file CLI tools logs.

To show build settings in terminal window (or in Codemagic), use xcode-project build-ipa with --verbose flag.

Motivation: help with debugging iOS build failures

@priitlatt priitlatt added the enhancement New feature or request label Sep 28, 2022
Copy link
Contributor

@priitlatt priitlatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog is not updated.

src/codemagic/models/xcodebuild.py Outdated Show resolved Hide resolved
src/codemagic/models/xcodebuild.py Outdated Show resolved Hide resolved
src/codemagic/models/xcodebuild.py Outdated Show resolved Hide resolved
src/codemagic/tools/xcode_project.py Outdated Show resolved Hide resolved
Copy link
Contributor

@priitlatt priitlatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose this change is significant enough to warrant a change of minor version, not only the patch.

Additionally:

  • There could be cases when showing build settings is not desirable and as such I think we should have a way to disable it.
  • To follow already existing patterns (like with clean), then it would be nice to add a standalone action also for showing build settings, like xcode-project show-build-settings, that does only this one thing.

CHANGELOG.md Outdated Show resolved Hide resolved
@artemii-yanushevskyi artemii-yanushevskyi merged commit a9e06bb into master Sep 29, 2022
@artemii-yanushevskyi artemii-yanushevskyi deleted the feature/log-project-build-settings branch September 29, 2022 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants