Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependencies: Remove pyOpenSSL dependency #269

Merged
merged 7 commits into from
Oct 4, 2022
Merged

Dependencies: Remove pyOpenSSL dependency #269

merged 7 commits into from
Oct 4, 2022

Conversation

priitlatt
Copy link
Contributor

@priitlatt priitlatt commented Sep 30, 2022 •
edited
Loading

It is not advised to use pyOpenSSL by Python Cryptographic Authority. As stated on pyOpenSSL project PyPI page:

Note: The Python Cryptographic Authority strongly suggests the use of pyca/cryptography where possible. If you are using pyOpenSSL for anything other than making a TLS connection you should move to cryptography and drop your pyOpenSSL dependency.

Also all recent issues related to third party dependencies have originated from cryptography and pyOpenSSL compatibility problems.

With this PR reliance on pyOpenSSL library is removed from codemagic-cli-tools.

@priitlatt priitlatt added the dependencies Pull requests that update a dependency file label Sep 30, 2022
@priitlatt priitlatt marked this pull request as ready for review September 30, 2022 15:42
artemii-yanushevskyi
artemii-yanushevskyi requested changes Oct 4, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
src/codemagic/models/private_key.py Outdated Show resolved Hide resolved
tests/conftest.py Outdated Show resolved Hide resolved
src/codemagic/models/private_key.py Show resolved Hide resolved
@priitlatt @artemii-yanushevskyi
Apply suggestions from code review
b5b36cb 
Co-authored-by: Artemii <40743076+artemii-yanushevskyi@users.noreply.github.com>
@priitlatt priitlatt merged commit 5aeab02 into master Oct 4, 2022
@priitlatt priitlatt deleted the dependencies/remove-pyopenssl-dependency branch October 4, 2022 09:21
@priitlatt priitlatt mentioned this pull request Feb 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemii-yanushevskyi artemii-yanushevskyi artemii-yanushevskyi approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@priitlatt @artemii-yanushevskyi