Bugfix: Remove mutable default usage from Keystore model declaration

.github/workflows/run-checks.yml

@@ -5,12 +5,12 @@ on:
   pull_request:
 
 jobs:
-  test:
-
+  test-py-3-7:
     runs-on: ubuntu-latest
 
     steps:
     - uses: actions/checkout@v1
+
     - name: Set up Python 3.7
       uses: actions/setup-python@v1
       with:
@@ -40,3 +40,39 @@ jobs:
 
     - name: Test with pytest
       run: poetry run pytest
+
+  test-py-3-11:
+    runs-on: ubuntu-latest
+
+    steps:
+    - uses: actions/checkout@v1
+
+    - name: Set up Python 3.11
+      uses: actions/setup-python@v1
+      with:
+        python-version: 3.11
+
+    - uses: actions/cache@v1
+      with:
+        path: ~/.cache/pip
+        key: ${{ runner.os }}-pip-${{ hashFiles('**/poetry.lock') }}
+        restore-keys: |
+          ${{ runner.os }}-pip-
+
+    - name: Install dependencies
+      run: |
+        curl -sSL https://install.python-poetry.org | python
+        poetry config virtualenvs.in-project true
+        poetry install --no-interaction
+
+    - name: Check code formatting
+      run: poetry run flake8 .
+
+    - name: Check imports sort order
+      run: poetry run isort --check-only .
+
+    - name: Static type checks with mypy
+      run: poetry run mypy src
+
+    - name: Test with pytest
+      run: poetry run pytest

CHANGELOG.md

@@ -1,3 +1,9 @@
+Version 0.36.2
+-------------
+
+**Bugfix**
+- Remove mutable default value from `codemagic.models.Keystore` field `certificate_attributes`. [PR #284](https://github.com/codemagic-ci-cd/cli-tools/pull/284)
+
 Version 0.36.1
 -------------
 

pyproject.toml

@@ -1,6 +1,6 @@
 [tool.poetry]
 name = "codemagic-cli-tools"
-version = "0.36.1"
+version = "0.36.2"
 description = "CLI tools used in Codemagic builds"
 readme = "README.md"
 authors = [

src/codemagic/__version__.py

@@ -1,5 +1,5 @@
 __title__ = 'codemagic-cli-tools'
 __description__ = 'CLI tools used in Codemagic builds'
-__version__ = '0.36.1.dev'
+__version__ = '0.36.2.dev'
 __url__ = 'https://github.com/codemagic-ci-cd/cli-tools'
 __licence__ = 'GNU General Public License v3.0'

src/codemagic/cli/action_group.py

@@ -7,5 +7,7 @@ class ActionGroupProperties(NamedTuple):
     description: str
 
 
-class ActionGroup(ActionGroupProperties, enum.Enum):
+# mypy yields a false-positive type error on enums with multiple inheritance
+# https://github.com/python/mypy/issues/9319
+class ActionGroup(ActionGroupProperties, enum.Enum):  # type: ignore
     ...

src/codemagic/models/keystore.py

@@ -1,5 +1,6 @@
 import pathlib
 from dataclasses import dataclass
+from dataclasses import field
 
 from .certificate_attributes import CertificateAttributes
 
@@ -10,5 +11,5 @@ class Keystore:
     key_password: str
     store_password: str
     store_path: pathlib.Path
-    certificate_attributes: CertificateAttributes = CertificateAttributes()
+    certificate_attributes: CertificateAttributes = field(default_factory=CertificateAttributes)
     validity: int = 10000  # Validity duration in days