Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundletool version to 1.13.1 #287

Merged
merged 4 commits into from
Nov 22, 2022

Conversation

VeArnold
Copy link
Contributor

@VeArnold VeArnold commented Nov 21, 2022

Closes #286.

The current version of bundletool is outdated and might cause issues for users with new projects.

In this PR, the bundletool version is pumped from 0.15.0 to 1.13.1

QA:

  • no breaking changes observed in bundletool release history
  • successful builds for a basic React Native and Flutter application using a codemagic pipeline with an upgraded version of cli-tools via PyPi test environment (version update and apk extraction from bundle) were run

The following android-app-bundle actions work as expected in a local environment (with a basic React native android bundle):

  • android-app-bundle bundletool version
  • android-app-bundle dump (tested with targets config, manifest, and resources)
  • android-app-bundle validate
  • android-app-bundle build-universal-apk

@VeArnold VeArnold marked this pull request as ready for review November 21, 2022 13:07
@VeArnold VeArnold requested a review from priitlatt November 21, 2022 13:07
@priitlatt priitlatt added bug Something isn't working dependencies Pull requests that update a dependency file labels Nov 21, 2022
Copy link
Contributor

@priitlatt priitlatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Test version is also available in PyPI test mirrot at https://test.pypi.org/project/codemagic-cli-tools/0.36.3.19/

@VeArnold VeArnold merged commit 4828bb7 into master Nov 22, 2022
@VeArnold VeArnold deleted the dependencies/pump-bundletool-version-to-1-33-1 branch November 22, 2022 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated bundletools
2 participants