Add missing fields for App Store Connect models #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…finitions/add-missing-fields-for-models
Comment on lines
+48
to
+69
| @pytest.fixture() | ||
| def app_store_connect(namespace_kwargs) -> AppStoreConnect: | ||
| args = AppStoreConnectArgument | ||
| if "TEST_APPLE_PRIVATE_KEY_PATH" in os.environ: | ||
| key_path = pathlib.Path(os.environ["TEST_APPLE_PRIVATE_KEY_PATH"]) | ||
| private_key = key_path.expanduser().read_text() | ||
| key_identifier = os.environ["TEST_APPLE_KEY_IDENTIFIER"] | ||
| issuer_id = os.environ["TEST_APPLE_ISSUER_ID"] | ||
| elif "TEST_APPLE_PRIVATE_KEY_CONTENT" in os.environ: | ||
| private_key = os.environ["TEST_APPLE_PRIVATE_KEY_CONTENT"] | ||
| key_identifier = os.environ["TEST_APPLE_KEY_IDENTIFIER"] | ||
| issuer_id = os.environ["TEST_APPLE_ISSUER_ID"] | ||
| else: | ||
| raise RuntimeError("Missing App Store Connect authentication information") | ||
|
|
||
| ns = namespace_kwargs | { | ||
| args.ISSUER_ID.key: Types.IssuerIdArgument(issuer_id), | ||
| args.KEY_IDENTIFIER.key: Types.KeyIdentifierArgument(key_identifier), | ||
| args.PRIVATE_KEY.key: Types.PrivateKeyArgument(private_key), | ||
| } | ||
| cli_args = argparse.Namespace(**ns) | ||
| return AppStoreConnect.from_cli_args(cli_args) |
There was a problem hiding this comment.
This fixture doesn't seem to be used anywhere in the codebase, can you elaborate what purpose it serves?
There was a problem hiding this comment.
You are quite right that as of now it is not used anywhere. But it is very useful for quickly testing out actual command invocations using tests instead of doing it from terminal with
python -m codemagic.toos.app_store_connect <action> <args> ...I could add an example test which uses this fixture, but is skipped unless live API tests are enabled. WDYT?
There was a problem hiding this comment.
I think let's add an example
There was a problem hiding this comment.
Added in 64ae629.
…finitions/add-missing-fields-for-models
artemii-yanushevskyi
approved these changes
Apr 26, 2024
Comment on lines
+13
to
+16
| def test_get_app(app_store_connect: AppStoreConnect): | ||
| app = app_store_connect.get_app(ResourceId("1481211155")) | ||
| assert isinstance(app, App) | ||
| assert app.id == "1481211155" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever App Store Connect API responses are converted to
codemagic.apple.resources.Apporcodemagic.apple.resources.Buildinstances, then the logs get flooded with warning about unknown fields for attributes and relationships.App warnings
Build warnings
Changes here add definitions for those fields.