Add option to expire builds only for selected platform #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Report in Codemagic CI/CD discussions: https://github.com/orgs/codemagic-ci-cd/discussions/2495
CLI option
--expire-build-submitted-for-reviewof actionapp-store-connect publishcan yield unexpected result by expiring build from the same application, but from another platform.As builds were not being filtered by platform when listing them for expiration, then it can happen that iOS build can be looked up and expired when publishing for macOS, or macOS build is expired when publishing iOS app. This is not desired and we should only expire builds that are of the same platform that is currently being published.
To achieve this, add optional
--platformswitch to actionapp-store-connect apps expire-build-submitted-for-reviewand use that option when invoking the action internally fromapp-store-connect publish.Updated actions:
app-store-connect apps builds- add optional--platformswitch to search only for builds with specified platform.app-store-connect apps expire-build-submitted-for-review- add optional--platformswitch to expire builds only for specified platform.app-store-connect builds list- add optional--platformswitch to search only for builds with specified platform.app-store-connect publish- only expire builds for the same platform that is being published when invoked with option--expire-build-submitted-for-review.