-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix using xcresulttool on Xcode 16.0 beta 3+ #424
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Starting from Xcode 16 beta 3 'xcresulttool get --format json' has been deprecated and | ||
cannot be used without '--legacy' flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Starting from Xcode 16 beta 3 'xcresulttool get --format json' has been deprecated and | |
cannot be used without '--legacy' flag. | |
Starting from Xcode 16 beta 3 'xcresulttool get' has been deprecated and | |
cannot be used without '--legacy' flag. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually xcresulttool get
itself is not deprecated. Up until version 23021 it used to just output the result bundle object, but now there are couple of subcommands that can be used, with objects
being the default.
Co-authored-by: Mohammed Babelly <mohammed@nevercode.io>
With Xcode 16.0 beta 3+ part of
xcresulttool
API that we use to parse Xcode test results has been deprecated:This causes
xcresulttool get object
calls with recent Xcode versions to exit with error and consequently some actions inxcode-project
fail.Apple has provided a quick workaround by providing
--legacy
flag that can be used to still use the old API even on more recentxcresulttool
version. Changes on this PR make use of that flag when callingxcresulttool get object
in casexcresulttool
version is at least23021
.Updated actions:
xcode-project run-tests
xcode-project test-summary
xcode-project junit-test-results
QA notes
Test are running and results can be successfully parsed using the following Xcode versions: