Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Android app build versioning #777

Merged
merged 3 commits into from
Apr 13, 2022
Merged

Android app build versioning #777

merged 3 commits into from
Apr 13, 2022

Conversation

priitlatt
Copy link
Contributor

Since google-play get-latest-build-version will allow using custom release tracks it would be nice if CM docs reflected that possibility too.

Other changes:

  • remove obsolete references environment variables with base64 encoded file values,
  • unify CLI args usage formatting,
  • remove Google reference from example package name.

@priitlatt priitlatt requested a review from helinanever April 12, 2022 14:05
@priitlatt
Copy link
Contributor Author

Do not merge before codemagic-ci-cd/cli-tools#215 is released.

helinanever
helinanever requested changes Apr 12, 2022
View reviewed changes
content/configuration/build-versioning.md Outdated Show resolved Hide resolved
content/configuration/build-versioning.md Outdated Show resolved Hide resolved
content/configuration/build-versioning.md Outdated Show resolved Hide resolved
content/yaml-quick-start/building-a-flutter-app.md Show resolved Hide resolved
@priitlatt @helinanever
Apply suggestions from code review
a9d1e32 
Co-authored-by: helinanever <36853001+helinanever@users.noreply.github.com>
helinanever
helinanever approved these changes Apr 12, 2022
View reviewed changes
Copy link
Collaborator

@helinanever helinanever left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@priitlatt priitlatt merged commit 9d80bd3 into master Apr 13, 2022
@mikhail-tokarev mikhail-tokarev deleted the improvements/android-build-versioning branch June 26, 2022 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helinanever helinanever helinanever approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@priitlatt @helinanever