-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inline CSS Highlight Patch #4646
base: master
Are you sure you want to change the base?
Conversation
Introduces an option inlineCssMode which when set to true enable highlighting of CSS in the style attribute. Can be extended to highlight JavaScript in attributes such as onclick, onmouseup e.t.c.
Hi. You're messing with the indentation and semicolons of lines that aren't affected by your patch. Please don't do that. Also please try to follow the coding style of the surrounding code with regards to spaces after What is |
Ah, sorry for the code indentation e.t.c. If we are in any HTML tag,
If we are in an HTML tag but it is that specific tag which was provided in
I came across this problem for Codemirror because where I work at, the developers used to work alot in the style attribute tweaking styles. I thought it might help. I ain't good and it's posted so, someone can improve on this and integrate it into CM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! This would be very useful for editing HTML with style and script tags.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
. |
Hey @phuongkt, stop adding empty reviews or I'll have to block you from the project. |
Reviewed 1 of 1 files at r1. mode/htmlmixed/htmlmixed.js, line 79 at r1 (raw file):
Why has this blank line been removed? I think it makes the code easier to read. Comments from Reviewable |
Improved the formatting of the code.
Review status: all files reviewed at latest revision, 3 unresolved discussions. mode/htmlmixed/htmlmixed.js, line 137 at r1 (raw file):
BTW these few lines have the incorrect indent. mode/htmlmixed/htmlmixed.js, line 140 at r1 (raw file):
BTW these three lines are indented incorrectly too Comments from Reviewable |
Improved formatting
Introduces an option inlineCssMode which when set to true enable highlighting of CSS in the style attribute. Can be extended to highlight JavaScript in attributes such as onclick, onmouseup e.t.c.