Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug where vim new line creates a permanent thick cursor #5547

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

goofiw
Copy link

@goofiw goofiw commented Aug 26, 2018

No description provided.

@adrianheine
Copy link
Contributor

Thanks for your contribution! I can reproduce the issue and your changes indeed fix it. I wonder what the root cause for this issue is and if there's a better way to fix it, though.

@marijnh
Copy link
Member

marijnh commented Sep 20, 2018

I agree that this looks like it's fixing the issue on the wrong level. Could you say a bit more about how you diagnosed this and why making the mode change asynchronous helps?

@goofiw
Copy link
Author

goofiw commented Oct 4, 2018

@marijnh honestly I don't remember what it was. I think it had to do with the way operations (src/display/operations.js) were getting batched, events were happening out of order and the that is the thick curser wasn't getting removed properly.

It was 6 weeks ago, but I think another issue of using the operations module was the operation functionality wasn't exported.

Setting the timeout is just a hack for putting off the new line command to the next pass of the run loop so it happens after the current reconciliation of the render steps (and, yea, does another pass through the render steps).

The

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants