Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Support string templates in Kotlin mode #5609

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AlexanderPrendota
Copy link
Contributor

Hello @marijnh !

Kotlin is supported string templates. A template expression starts with a dollar sign ($) and consists of either a simple name:
screen shot 2018-10-08 at 3 18 40 pm

Now in kotlin mode we have plain string. I notice the gradle mode supports string templates.

I tried to use the same logic to kotlin mode.
Unfortunately, I do not know the codemirror API.

I would be happy if you give some advice or help with string templates in kotlin mode.
Probably it's actual in C# mode too.

Thanks!

@marijnh
Copy link
Member

marijnh commented Oct 8, 2018

I'm not willing to walk you through implementing this—but if you read the docs and look at some other modes that have the same issue, I'm sure you can figure it out!

@AlexanderPrendota
Copy link
Contributor Author

Hm! I saw same issue in 2 modes: groovy and shell. So I implemented like in groovy mode but I can't find the mistake I did.

Okay! I will try again. I thought you could take a look on my solution.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants