-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Flow language mode #5920
base: master
Are you sure you want to change the base?
Add Flow language mode #5920
Conversation
I also found bug with |
Hi, thanks for the contribution. But we aren't including new modes into the main distribution anymore. The recommended way to distribute code like this is to put it into its own npm package with a name like codemirror-mode-flow |
Ah, I see you extended the javascript mode, rather than adding it as a new mode. I'll look into this in more detail next week, though my first thought is that that mode is already way too complex as it is. |
Though it does add more complexity to an already big mode, this is a very solid PR implementing a useful feature, so I guess I have no choice but to merge it 😄 |
On closer look, it seems that a lot of the failing tests are not intentional. Could you take care of those first? |
There's bug with |
Right, but there's a bunch of tests failing that don't use that construct. |
You mean with indentation? |
https://flow.org