Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css mode] add caseInsensitive hint #6855

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Realetive
Copy link

Current PR allow to invoke CSS hint for property or value in any case:

Снимок экрана 2021-12-24 в 00 07 14

Снимок экрана 2021-12-24 в 00 07 35

@@ -41,7 +41,7 @@
function add(keywords) {
for (var name in keywords)
if (!word || name.lastIndexOf(word, 0) == 0)
result.push(name);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This definitely won't work for pseudoClasses defined above. What is it intended to do?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS is not case-sensitive. The current solution doesn't work with properties and values that the user will camelCase (ex. optimizeSpeed instead of optimizespeed). I want to fix this. Do you have any idea how to solve the problem with pseudoClasses?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I mean, given that keySet is only called with lower-case strings, what is the purpose of making the object values hold another copy of the string?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants