Update InPlaceEditView.java #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ImmediandoSrl
commented
Jun 11, 2024
ImmediandoSrl
commented
- Add support for KEYTAB on physical keyboard
- Add custom client property for TextField component that select all text on focus
- Add support for KEYTAB on physical keyboard - Add custom client property for TextField component that select all text on focus
Closed
|
This PR looks good except for the changes to I commented on the problematic nature of the changes in #3808 in that PR so I won't repeat that here. Because of that dependency I can't approve a build so I can't test the code to see if it compiles. Once these fixes are made I'll approve a run and we can see if this compiles. |
|
ok removed getNextComponent changes |
|
Thanks! @all-contributors please add @ImmediandoSrl for code |
|
I've put up a pull request to add @ImmediandoSrl! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.