Bootstrap support #107
Open
Bootstrap support #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Si deciden soportar bootstrap, opino que lo mejor sería utilizar los estilos por defecto que define para la apariencia de los componentes comunes, esto sería dejar de usar los estilos nuestros para dichos componentes (por ejemplo para tablas sería eliminar los estilos definidos en for-client/css/my-tables.styl para el selector .my-grid (salvo para cosas puntuales de funcionalidades (hover por ej))). Luego si se quiere modificar/extender la apariencia en algún aspecto que bootstrap no contempla, entonces se haría en css/styl los cambios puntuales. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuación del PR #102 en respuesta a los comentarios de Emilio (Github no permite re-abrir pull request cerrados y mergeados (el 102 está mergeado porque le hice un merge en otro branch para cambiarle el nombre original "myFirstContribution"))