Immudb 1.3.2 with backward compability fix #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeroiraz
reviewed
Aug 31, 2022
immudb/handler/get.py
Outdated
| @@ -26,7 +26,7 @@ def call(service: schema_pb2_grpc.ImmuServiceStub, rs: RootService, key: bytes, | |||
| try: | |||
| msg = service.Get(request) | |||
| except Exception as e: | |||
| if hasattr(e, 'details') and e.details() == 'key not found': | |||
| if hasattr(e, 'details') and (e.details() == 'key not found' or e.details() == 'tbtree: key not found'): | |||
There was a problem hiding this comment.
I'd suggest checking for the substring key not found. Next immudb release will expose error codes, making error handling easier and less error prone
There was a problem hiding this comment.
I can check with endswith() method
If i would simply check for if string is in string then we would have another backward compability issue - with expiration.
Right now in immudb-py expiration returns error instead of None, so when i would check simply for existency of "key not found" in a string - it would start to returns None
if anyone right now are using this function and opaque it in try catch - try catch would stop working
This should be handled properly and consistent, but right now is not
jeroiraz
approved these changes
Sep 1, 2022
mabmayer
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.