chore(embedded/sql): improve internal index naming

Signed-off-by: Jeronimo Irazabal <jeronimo.irazabal@gmail.com>
codenotary · Sep 20, 2023 · b89c956 · b89c956
1 parent d4568d3
commit b89c956
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 7 deletions.
diff --git a/embedded/sql/catalog.go b/embedded/sql/catalog.go
@@ -253,7 +253,7 @@ func indexName(tableName string, cols []*Column) string {
 
 	buf.WriteString(tableName)
 
-	buf.WriteString("[")
+	buf.WriteString("(")
 
 	for c, col := range cols {
 		buf.WriteString(col.colName)
@@ -263,7 +263,7 @@ func indexName(tableName string, cols []*Column) string {
 		}
 	}
 
-	buf.WriteString("]")
+	buf.WriteString(")")
 
 	return buf.String()
 }

diff --git a/embedded/sql/engine_test.go b/embedded/sql/engine_test.go
@@ -6054,14 +6054,14 @@ func TestSingleDBCatalogQueries(t *testing.T) {
 		row, err := r.Read(context.Background())
 		require.NoError(t, err)
 		require.Equal(t, "mytable1", row.ValuesBySelector["(indexes.table)"].RawValue())
-		require.Equal(t, "mytable1[id]", row.ValuesBySelector["(indexes.name)"].RawValue())
+		require.Equal(t, "mytable1(id)", row.ValuesBySelector["(indexes.name)"].RawValue())
 		require.True(t, row.ValuesBySelector["(indexes.unique)"].RawValue().(bool))
 		require.True(t, row.ValuesBySelector["(indexes.primary)"].RawValue().(bool))
 
 		row, err = r.Read(context.Background())
 		require.NoError(t, err)
 		require.Equal(t, "mytable1", row.ValuesBySelector["(indexes.table)"].RawValue())
-		require.Equal(t, "mytable1[title]", row.ValuesBySelector["(indexes.name)"].RawValue())
+		require.Equal(t, "mytable1(title)", row.ValuesBySelector["(indexes.name)"].RawValue())
 		require.False(t, row.ValuesBySelector["(indexes.unique)"].RawValue().(bool))
 		require.False(t, row.ValuesBySelector["(indexes.primary)"].RawValue().(bool))
 
@@ -6078,21 +6078,21 @@ func TestSingleDBCatalogQueries(t *testing.T) {
 		row, err := r.Read(context.Background())
 		require.NoError(t, err)
 		require.Equal(t, "mytable2", row.ValuesBySelector["(indexes.table)"].RawValue())
-		require.Equal(t, "mytable2[id]", row.ValuesBySelector["(indexes.name)"].RawValue())
+		require.Equal(t, "mytable2(id)", row.ValuesBySelector["(indexes.name)"].RawValue())
 		require.True(t, row.ValuesBySelector["(indexes.unique)"].RawValue().(bool))
 		require.True(t, row.ValuesBySelector["(indexes.primary)"].RawValue().(bool))
 
 		row, err = r.Read(context.Background())
 		require.NoError(t, err)
 		require.Equal(t, "mytable2", row.ValuesBySelector["(indexes.table)"].RawValue())
-		require.Equal(t, "mytable2[name]", row.ValuesBySelector["(indexes.name)"].RawValue())
+		require.Equal(t, "mytable2(name)", row.ValuesBySelector["(indexes.name)"].RawValue())
 		require.False(t, row.ValuesBySelector["(indexes.unique)"].RawValue().(bool))
 		require.False(t, row.ValuesBySelector["(indexes.primary)"].RawValue().(bool))
 
 		row, err = r.Read(context.Background())
 		require.NoError(t, err)
 		require.Equal(t, "mytable2", row.ValuesBySelector["(indexes.table)"].RawValue())
-		require.Equal(t, "mytable2[name,active]", row.ValuesBySelector["(indexes.name)"].RawValue())
+		require.Equal(t, "mytable2(name,active)", row.ValuesBySelector["(indexes.name)"].RawValue())
 		require.True(t, row.ValuesBySelector["(indexes.unique)"].RawValue().(bool))
 		require.False(t, row.ValuesBySelector["(indexes.primary)"].RawValue().(bool))