Promote scrollable-region-focusable per dequelabs/axe-core#3959

codeofdusk · Jul 30, 2023 · d09b2be · d09b2be
1 parent 240b2e5
commit d09b2be
Show file tree

Hide file tree

Showing 5 changed files with 1 addition and 17 deletions.
diff --git a/src/common/components/cards/rich-resolution-content.tsx b/src/common/components/cards/rich-resolution-content.tsx
@@ -80,14 +80,6 @@ export const RichResolutionContent = NamedFC<RichResolutionContentProps>(
                     </div>
                 );
             }
-            case 'web/scrollable-region-focusable': {
-                return (
-                    <span>
-                        Examine the element and ensure that, if there is scrollable content, the
-                        elements are accessible by keyboard.
-                    </span>
-                );
-            }
             case 'web/label-content-name-mismatch': {
                 return (
                     <span>

diff --git a/src/scanner/get-rule-inclusions.ts b/src/scanner/get-rule-inclusions.ts
@@ -47,18 +47,13 @@ export const explicitRuleOverrides: DictionaryStringTo<RuleIncluded> = {
         status: 'included',
         reason: 'best practice rule that was investigated with no known false positives, implemented as an automated check.',
     },
-    'scrollable-region-focusable': {
-        status: 'excluded',
-        reason: 'only reports to needs-review results due to potential false-positives',
-    },
 };
 
 // all the rules we enable in needs review
 export const needsReviewRules = [
     'aria-input-field-name',
     'color-contrast',
     'th-has-data-cells',
-    'scrollable-region-focusable',
     'label-content-name-mismatch',
     'p-as-heading',
 ];

diff --git a/src/tests/unit/tests/common/components/cards/rich-resolution-content.test.tsx b/src/tests/unit/tests/common/components/cards/rich-resolution-content.test.tsx
@@ -19,7 +19,6 @@ describe('RichResolutionContent', () => {
         'web/aria-input-field-name',
         'web/color-contrast',
         'web/th-has-data-cells',
-        'web/scrollable-region-focusable',
         'web/label-content-name-mismatch',
         'web/p-as-heading',
     ])('renders static content with id=%s', testId => {

diff --git a/src/tests/unit/tests/common/self-fast-pass.test.ts b/src/tests/unit/tests/common/self-fast-pass.test.ts
@@ -71,7 +71,6 @@ describe('SelfFastPass', () => {
                             'aria-input-field-name',
                             'color-contrast',
                             'th-has-data-cells',
-                            'scrollable-region-focusable',
                             'label-content-name-mismatch',
                             'p-as-heading',
                         ],

diff --git a/src/tests/unit/tests/scanner/__snapshots__/get-rule-inclusions.test.ts.snap b/src/tests/unit/tests/scanner/__snapshots__/get-rule-inclusions.test.ts.snap
@@ -296,8 +296,7 @@ exports[`getRuleInclusions getRuleInclusions matches snapshotted list of product
     "status": "excluded",
   },
   "scrollable-region-focusable": {
-    "reason": "only reports to needs-review results due to potential false-positives",
-    "status": "excluded",
+    "status": "included",
   },
   "select-name": {
     "status": "included",