Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/NodeCG-CI #327

Merged
merged 4 commits into from
Nov 27, 2021
Merged

feat/NodeCG-CI #327

merged 4 commits into from
Nov 27, 2021

Conversation

TimTechDev
Copy link
Contributor

@TimTechDev TimTechDev commented Nov 22, 2021

Minimize runtime errors by actually trying to run our
framework with NodeCG. This CI will run on push and
pull requests to the main branch.

As suggested in the discussion following #325.

Minimize runtime errors by actually trying to run our
framework with NodeCG. This CI will run on push and
pull requests to the main branch.

    Tim

Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
@TimTechDev
Copy link
Contributor Author

The action is failing because NodeCG wants to write to folders it should not.

https://github.com/Tim-Tech-Dev/nodecg-io/runs/4292590810

@hlxid
Copy link
Member

hlxid commented Nov 23, 2021

NodeCG only seems to work when given a absolute path to the bundle directories, at least if the bundle directories are in nested sub directories. To fix this we can provide the full path using the main directory you currently already log at the beginning: hlxid@b377853.
I would recommend integrating this check into our current CI check. Both check that our project can be compiled and having two seperate workflows for this don't really provide an advantage other than the workflow without the NodeCG run check runs a bit faster.

@TimTechDev
Copy link
Contributor Author

I would suggest using the $GITHUB_WORKSPACE environment variable. So we don't rely on the path of the runner.

@hlxid
Copy link
Member

hlxid commented Nov 24, 2021

Thats a good suggestion! Do you want to integrate the changes of the above mentionted commit or shall I update it to use the environment variable and create a PR against this PR?

- Fix the NodeCG config by supplying an absolute path
- Move the action to the main CI workflow

    Tim

Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
@TimTechDev
Copy link
Contributor Author

I missed the working-directory values in my commit.

- Format ci.yml
- Use `working-directory` feature inside run scripts
- Add a bit of documentation

    Tim

Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
@TimTechDev
Copy link
Contributor Author

Added the NodeCG runt to the publishing requirements.

@TimTechDev TimTechDev marked this pull request as ready for review November 27, 2021 13:14
Copy link
Member

@hlxid hlxid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much

@hlxid hlxid merged commit cdc2a1f into codeoverflow-org:main Nov 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants