-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat/NodeCG-CI #327
feat/NodeCG-CI #327
Conversation
Minimize runtime errors by actually trying to run our framework with NodeCG. This CI will run on push and pull requests to the main branch. Tim Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
The action is failing because NodeCG wants to write to folders it should not. https://github.com/Tim-Tech-Dev/nodecg-io/runs/4292590810 |
NodeCG only seems to work when given a absolute path to the bundle directories, at least if the bundle directories are in nested sub directories. To fix this we can provide the full path using the main directory you currently already log at the beginning: hlxid@b377853. |
I would suggest using the |
Thats a good suggestion! Do you want to integrate the changes of the above mentionted commit or shall I update it to use the environment variable and create a PR against this PR? |
- Fix the NodeCG config by supplying an absolute path - Move the action to the main CI workflow Tim Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
I missed the |
- Format ci.yml - Use `working-directory` feature inside run scripts - Add a bit of documentation Tim Signed-off-by: Tim_Tech_Dev <Tim_Tech_Dev@protonmail.com>
Added the NodeCG runt to the publishing requirements. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much
Minimize runtime errors by actually trying to run our
framework with NodeCG. This CI will run on push and
pull requests to the main branch.
As suggested in the discussion following #325.