ci/improve itegration test #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use `@manypkg/get-packages` to collect the packages in the workspace (like in our other scripts). Thus improving the legibility. - Improving the log output by decluttering it - Add confirmation, in case no errors were thrown
The implications of https://nodejs.org/api/child_process.html#subprocesskillsignal and the possibility of killing other process, implied using the integrated timeout option. Also, `stdout` is now collected in a Buffer and is only converted after NodeCG stopped. This is needed in case the data of a single line is split up into to calls which would brake the previous implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.