Add NodeCG v2 support #896
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of NodeCG v2 compilation results aren't checked into the repository anymore and NodeCG has to be built after cloning it.
The previous range would have included all major NodeCG bumps, while this only includes v1 and v2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've tested NodeCG v2 with nodecg-io before NodeCG v2 was released which worked fine.\nNow that it has been released there have been two problems preventing it from fully working:
NodeCG v2 was not included in the NodeCG version range that our bundles work with because the
^semver2 operator does not include major updates.The NodeCG test CI workflow job was broken because build results are not checked into the NodeCG repository anymore so NodeCG must be built in CI (this is cached)