-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Coder plugin): Update integration with Backstage's identity API #118
Conversation
mockCoderAuthToken, | ||
mockBackstageProxyEndpoint as root, | ||
} from './mockBackstageData'; | ||
import type { Workspace, WorkspacesResponse } from '../typesConstants'; | ||
import { CODER_AUTH_HEADER_KEY } from '../api'; | ||
|
||
type RestResolver<TBody extends DefaultBodyType = any> = ResponseResolver< |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not a huge fan of needing to bust out the any
type for these MSW helper types, but it's what MSW itself is using, and trying to make things more specific got nasty
@code-asher Would definitely appreciate your perspective on the token stuff. I was aware of bearer tokens, but for all the companies I've worked for so far, they were abstracted out enough on the frontend that I never needed to touch them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Closes #116
Changes made
Notes