Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: update codebase to use API classes #122

Closed
wants to merge 154 commits into from
Closed

refactor: update codebase to use API classes #122

wants to merge 154 commits into from

Conversation

Parkreiner
Copy link
Collaborator

@Parkreiner Parkreiner commented Apr 23, 2024 •
edited
Loading

Closed in favor of making smaller, more atomic PRs

@Parkreiner
wip: update type definitions and parsing logic for config values
17fd4d3
@Parkreiner
refactor: update some code for clarity
a95a44b
@Parkreiner
fix: update property names in top-level config
18e80f0
@Parkreiner
wip: commit progress on link update
3cfc7c5
@Parkreiner
chore: finish updates for CreateWorkspaceLink
ec1e794
@Parkreiner
chore: add new test case for disabled state
50ad128
@Parkreiner
fix: cleanup markup and text for EntityDataReminder
bbcdaf7
@Parkreiner
chore: add readEntityData as context value
730e979
@Parkreiner
refactor: rename DataEntityReminder to ReminderAcoordionItem
cd804f6
@Parkreiner
chore: extract core accordion item logic to parent
9e541c2
@Parkreiner
chore: finish initial version of ReminderAccordion
f445df4
@Parkreiner
wip: commit test stubs for ReminderAccordion
f841d1a
@Parkreiner
chore: rename isReadingEntityData prop
98a94c8
@Parkreiner
chore: update mock context values in tests
d2ac1ac
@Parkreiner
wip: commit test stub for hiding cta button when there is no repo URL
b415ce5
@Parkreiner
chore: hide CTA button when there is no repo URL
604c7a4
@Parkreiner
chore: rename AccordionItem to Disclosure
8635663
@Parkreiner
chore: update tests for Disclosure
233d255
@Parkreiner
chore: remove needless hasAssertions calls
badd8ee
@Parkreiner
fix: update conditional logic for ReminderAccordion
e87e41e
@Parkreiner
fix: more accordion bug fixes
52a2731
@Parkreiner
chore: finish another test case
c45e132
@Parkreiner
chore: add another accordion test case
0680934
@Parkreiner
refactor: rename props for clarity
7ba9fce
@Parkreiner
refactor: simplify condition for entity reminder
14c4d86
@Parkreiner
refactor: update prop for Disclosure
8f5081e
@Parkreiner
chore: finish all tests for accordion
11b7b81
@Parkreiner
refactor: update type definition for mock config
cb2664e
@Parkreiner
refactor: polish up accordion tests
41d6f20
@Parkreiner
chore: finish up all tests
b3b83f0
@Parkreiner
wip: commit progress on CoderTokenAuth
a316b89
@Parkreiner
fix: update state setter to account for empty tokens
47f2af8
@Parkreiner
wip: commit current test progress
992d98e
@Parkreiner
wip: finish majority of token auth tests
6ad14dc
@Parkreiner
chore: finalize CoderTokenAuth tests
dd2fd51
@Parkreiner
docs: update names of test cases for clarity
6a672d6
@Parkreiner
refactor: make time dependencies easier to manage
4b64d77
@Parkreiner
fix: add types to Backstage error class
3fda9f0
@Parkreiner
Merge branch 'main' into mes/api-refactor
f2d8716
@Parkreiner
fix: add IdentityApi to CoderClient class definition
edde14a
@Parkreiner
refactor: clean up type parameters
0ae3a1b
@Parkreiner
wip: commit progress on CoderClient tests
0b47f29
@Parkreiner
wip: add all test cases for coder client
fc778c7
@Parkreiner
refactor: clean up up Axios code for clarity and make sure values sta…
14baf98 
…y bound
@Parkreiner
fix: turn session token logic into default middleware
5620d8b
@Parkreiner
wip: commit progress on failing, non-isolated tests
579ad88
@Parkreiner
fix: update issue with auth state changes not propagating to coder cl…
e5f4393 
…ient
@Parkreiner
fix: make sure client can clean up after itself after tests
b032f18
@Parkreiner
refactor: simplify cleanup process for using CoderClient in tests
723207a
@Parkreiner
fix: add support for aborting all pending requests on cleanup
c8aaf60
@Parkreiner
refactor: consolidate ad-hoc coder client hook calls
323fcf2
@Parkreiner
refactor: rename internal property to make it less discoverable
6b5f7c9
@Parkreiner
refactor: make internals even less discoverable
4659647
@Parkreiner
refactor: make internals less clunky
e26b4a8
@Parkreiner
docs: improve private message clarity
54c5a2a
@Parkreiner Parkreiner self-assigned this Apr 23, 2024
@Parkreiner Parkreiner closed this Apr 23, 2024
@Parkreiner Parkreiner changed the title TEMP: this is 100% expected to fail chore: never mind Apr 25, 2024
@Parkreiner Parkreiner changed the title chore: never mind refactor: update codebase to use API classes Apr 25, 2024
@Parkreiner Parkreiner deleted the mes/api-refactor branch May 8, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Parkreiner Parkreiner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Parkreiner