chore: add missing unit tests for Coder plugin #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parkreiner
changed the title
Parkreiner
commented
Mar 27, 2024
| @@ -138,76 +141,6 @@ export const CoderProviderWithMockAuth = ({ | |||
| ); | |||
| }; | |||
|
|
|||
| type ChildProps = EntityProviderProps; | |||
There was a problem hiding this comment.
You can ignore this entire red section – these were bad test helpers that didn't do what they were supposed to. They're just deleted and aren't moved anywhere – I added a new test helper towards the bottom of the file
Parkreiner
commented
Mar 27, 2024
| </TestApiProvider> | ||
| ); | ||
|
|
||
| return wrapInTestApp(mainMarkup) as unknown as typeof mainMarkup; |
There was a problem hiding this comment.
There are some strange type mismatches in Backstage. wrapInTestApp is supposed to give you back a React component, which you should be able to plug into RTL's functions
But the type is slightly off, so even though things won't break at runtime, the compiler will complain
code-asher
approved these changes
Mar 28, 2024
| expect(unlinkCoderAccount).toHaveBeenCalled(); | ||
| }); | ||
|
|
||
| it('Lets users trigger actions entirely through the keyboard', async () => { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves one of the to-do items in #8
Changes made
CoderAuthWrapperCoderWorkspacesCardsub-componentsCoderAuthWrappermore user-friendlyCoderAuthInputFormNotes