Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlink socket at start #1538

Closed
nhooyr opened this issue Apr 17, 2020 · 2 comments
Closed

Unlink socket at start #1538

nhooyr opened this issue Apr 17, 2020 · 2 comments
Assignees
@nhooyr
Labels
bug Something isn't working
Milestone
v3.6.0

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Apr 17, 2020

See #1466
@nhooyr nhooyr added the bug Something isn't working label Apr 17, 2020
@nhooyr nhooyr self-assigned this Apr 17, 2020
@TheTyrius TheTyrius mentioned this issue Apr 29, 2020
Open
@nhooyr
Copy link
Contributor Author

nhooyr commented May 1, 2020

Probably better to always unlink any existing socket at the path. But will need to see what other software does.

@nhooyr nhooyr changed the title Cleanup unix socket on exit Unlink socket at start May 1, 2020
@nhooyr
Copy link
Contributor Author

nhooyr commented May 1, 2020

Relevant caddy issue caddyserver/caddy#3269

@nhooyr nhooyr added this to the v3.5.1 milestone Aug 30, 2020
nhooyr added a commit that referenced this issue Oct 9, 2020
@nhooyr
Unlink socket before using
e520087 
See https://stackoverflow.com/a/34881585/4283659

Closes #1538
@nhooyr nhooyr mentioned this issue Oct 9, 2020
Merged
nhooyr added a commit that referenced this issue Oct 9, 2020
@nhooyr
Unlink socket before using (#2181)
2d1de74 
See https://stackoverflow.com/a/34881585/4283659

Closes #1538
@nhooyr nhooyr closed this as completed Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nhooyr nhooyr

Labels
bug Something isn't working
Projects
None yet
Milestone
v3.6.0
Development

No branches or pull requests
1 participant
@nhooyr