Remove unmaintained CI images and update release workflow #3147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
suggested changes
Apr 16, 2021
.github/workflows/publish.yaml
Outdated
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| name: npm-package |
There was a problem hiding this comment.
What is this name environment variable used for? (Just curious)
oxy
commented
Apr 16, 2021
.github/workflows/publish.yaml
Outdated
Comment on lines
17
to
20
| - name: Download npm package | ||
| uses: actions/download-artifact@v2 | ||
| with: | ||
| args: ./ci/steps/publish-npm.sh | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| NPM_TOKEN: ${{ secrets.NPM_TOKEN }} | ||
| name: npm-package |
There was a problem hiding this comment.
Took a second look and need to fix this; npm-package is produced by the ci.yaml workflow, we need to fetch it from there, this won't work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ci/images/debian10was removed in a previous PR, but we still used it in our publish flow... this should fix that, and also update our documentation to stop referring to those images.Closes #3142.