-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce extraInitContainers to helm chart #3393
Conversation
Codecov Report
@@ Coverage Diff @@
## main #3393 +/- ##
=======================================
Coverage 59.21% 59.21%
=======================================
Files 35 35
Lines 1709 1709
Branches 379 379
=======================================
Hits 1012 1012
Misses 559 559
Partials 138 138 Continue to review full report at Codecov.
|
Thanks for making your first contribution! 🙂 |
Thanks for opening an issue and raising a PR @strowk 🎉 This sounds like a great addition but would love to get some extra eyes on it from the other code-server team members. In the meantime, can you:
|
cc @alexgorbatchev and @Matthew-Beckett - any chance either of you would be able to help review this? |
d4cbc69
to
2d8b07a
Compare
@jsjoeio , rebased on main and also updated changelog. I guess that next version should be |
New extraInitContainers configuration added. It allows to pass template with a list of containers to execute before main code-server container started. Main container will only start when all init containers are completed (exited with 0 code). Additionally changes the way extraContainers is used - instead of toYaml use tpl, because this allows to reference any values from extraContainers string.
2d8b07a
to
1ffca57
Compare
Upd: changed entry in changelog to "Next Version" for now, guess there could be more stuff in there before next release.. (sorry for after review change) |
@strowk thanks for making those changes! Using "Next Version" in the @Matthew-Beckett looks good from our side. Thanks so much for reviewing this so quickly and helping out with maintaining code-server! We really appreciate it. |
New extraInitContainers configuration added.
It allows to pass template with a list of containers to execute before
main code-server container started. Main container will only start when
all init containers are completed (exited with 0 code).
Additionally changes the way extraContainers is used - instead of
toYaml use tpl, because this allows to
reference any values from extraContainers string.
close #3392