chore: Update dependency requirements. Fix node version manager. #3831
Conversation
GirlBossRush
added
docs
| @@ -0,0 +1 @@ | |||
| .node-version | |||
There was a problem hiding this comment.
Included as a symlink to avoid version drifting between NVM and nodenv
| @@ -29,6 +29,7 @@ Here is what is needed: | |||
|
|
|||
| - `node` v14.x | |||
| - `git` v2.x or greater | |||
| - [`git-lfs`](https://git-lfs.github.com) | |||
There was a problem hiding this comment.
I encountered a somewhat mysterious error when building the project on a clean slate. Turns out we need this too!
| @@ -0,0 +1 @@ | |||
| 14 | |||
There was a problem hiding this comment.
I dunno anything about nvm, though I'm curious why these tools don't inspect package.json's engine info for this?
Seems like a reasonable change to me though!
There was a problem hiding this comment.
Agreed, you would think it would be smarter!
There was a problem hiding this comment.
Ahh, open source 😆
Codecov Report
@@ Coverage Diff @@
## main #3831 +/- ##
=======================================
Coverage 62.05% 62.05%
=======================================
Files 36 36
Lines 1863 1863
Branches 378 378
=======================================
Hits 1156 1156
Misses 601 601
Partials 106 106 Continue to review full report at Codecov.
|
| @@ -0,0 +1 @@ | |||
| 14 | |||
There was a problem hiding this comment.
Agreed, you would think it would be smarter!
|
Minor note: if your PR isn't related to an issue, add the Milestone on the right side so we associate this work with the next release. I don't think it's as explicit as it should be in the docs, but more info here: https://coder.com/docs/code-server/v3.10.2/MAINTAINING#project-boards |
This PR addresses some minor doc changes, and adds files that allow NVM and nodenv to automatically switch to our preferred version.